ibc
(Iñaki Baz Castillo)
June 17, 2019, 4:19pm
21
Ohhhhhh
static void
rtp_session_process_pli (RTPSession * sess, guint32 sender_ssrc,
guint32 media_ssrc, GstClockTime current_time)
{
RTPSource *src;
if (!sess->callbacks.request_key_unit)
return;
src = find_source (sess, sender_ssrc);
if (src == NULL)
return;
rtp_session_request_local_key_unit (sess, src, media_ssrc, FALSE,
current_time);
}
That’s indeed wrong. It’s just looking at the sender ssrc
.
Ok, if you please can try tomorrow with the change I said and confirm it works, we may just apply it to mediasoup to make it works with “wrong” clients (I assume that setting the sender ssrc
to != 0 will not harm other RTP clients such as libwebrtc).
iTaybb
(Itay Brandes)
June 18, 2019, 8:11am
22
I’m having the same issue.
Looking forward for your kind solution
ibc
(Iñaki Baz Castillo)
June 18, 2019, 8:40am
23
The solution is already given above. If you can test and confirm it works we’ll commit it to mediasoup.
vpalmisano
(Vittorio Palmisano)
June 18, 2019, 1:30pm
24
ibc:
RTC::RTCP::FeedbackPsPliPacket packet(0, GetSsrc());
RTC::RTCP::FeedbackPsPliPacket packet(GetSsrc(), GetSsrc());
Confirmed: it works with GStreamer 1.14.1.
jmillan
(José Luis Millán Villegas)
June 18, 2019, 3:35pm
25
Thanks for the confirmation @vpalmisano .
koyaya
(Michael Herman)
June 18, 2019, 3:52pm
26
i was talking about a flow in which no rtcp back channel exists
picture-id-mode=1 indeed solved the problem, it worked even without the rtpbin (which is needed for rtcp)
1 Like
jmillan
(José Luis Millán Villegas)
June 20, 2019, 3:34pm
27
Sender SSRC is now filled with the media SSRC value in FIR and PLI requests.
New version of mediasoup has been released.
ibc
(Iñaki Baz Castillo)
June 24, 2019, 8:26am
28
What does picture-id-mode=1
exactly mean in GStreamer?
ibc
(Iñaki Baz Castillo)
June 24, 2019, 12:50pm
30
Question: I know what VP8 picture-id
is but, why is it required in GStreamer when no simulcast is used?
vpalmisano
(Vittorio Palmisano)
June 24, 2019, 2:41pm
31
I don’t know exactly. Leaving picture-id-mode to the default value doesn’t allow the receiver to consume the produced vp8 flow and the same using vp9. With ffmpeg there is no need to set anything.
ibc
(Iñaki Baz Castillo)
June 24, 2019, 2:55pm
32
Interesting. May it be related to the lack of “extended” bit in the VP8 payload? We rely on it to continue parsing the payload and detect whether it’s a keyframe:
/cc @jmillan
mkh
(Mohsen Khahani)
October 21, 2019, 5:24am
33
Would you please share the complete command you’ve used? And what gstreamer version are you using? I just can’t get it to work.
mkh
(Mohsen Khahani)
November 6, 2019, 3:17am
34
@vpalmisano Do you have any working gstreamer example or command?
1 Like