Why compile openssl with no_asm by default?

penguinol · May 15, 2020, 1:17pm

openssl asm is disabled by default in common.gypi
'openssl_no_asm%': 1, # Must be defined in OpenSSL >= 1.1.0g.
compile with asm_avx2 will increase performance by 10%~15%.
So is there any reason to disable asm?

aetheon · May 15, 2020, 1:59pm

I’ve noticed that the optimisation flags doesn’t seem to be used in g++ compilation, by looking at https://github.com/versatica/mediasoup/blob/v3/worker/compile_commands_template.json I don’t see any -O usage.

Any reason to not use them? they could bring some CPU performance improvements too. Its kinda of related to the above.

ibc · May 15, 2020, 6:11pm

Please, specify what exactly should be done. We will move from GYP to CMake soon, so I don’t want to spend much time on this.

penguinol · May 18, 2020, 3:20am

Okey, maybe i find the reason.
It seems the gyp config of openssl and mediasoup is reference to node.js
In previous version of nodejs, openssl_no_asm is set to 1 because of compile problem in arm64.

github.com/nodejs/node

build: re-enable openssl arm for arm64

committed 06:37PM - 25 Jul 19 UTC

vielmetti

+1 -6

In #23913 it looked like arm64 testing was flaky, and as a result a number of ch…anges were made including disabling openssl asm for that architecture. This PR is limited to re-enabling the one change to turn on openssl asm for arm64, in the hopes that either it works now, or that this specific change introduces a reproducible condition. See: https://github.com/nodejs/node/pull/23913 PR-URL: https://github.com/nodejs/node/pull/28180 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

But in the last version, it is set to 0.

github.com

nodejs/node/blob/main/common.gypi

{
  'variables': {
    'configuring_node%': 0,
    'asan%': 0,
    'werror': '',                     # Turn off -Werror in V8 build.
    'visibility%': 'hidden',          # V8's visibility setting
    'target_arch%': 'ia32',           # set v8's target architecture
    'host_arch%': 'ia32',             # set v8's host architecture
    'want_separate_host_toolset%': 0, # V8 should not build target and host
    'library%': 'static_library',     # allow override to 'shared_library' for DLL/.so builds
    'component%': 'static_library',   # NB. these names match with what V8 expects
    'msvs_multi_core_compile': '0',   # we do enable multicore compiles, but not using the V8 way
    'enable_pgo_generate%': '0',
    'enable_pgo_use%': '0',
    'python%': 'python',

    'node_shared%': 'false',
    'force_dynamic_crt%': 0,
    'node_use_v8_platform%': 'true',
    'node_use_bundled_v8%': 'true',

This file has been truncated. show original

To fix it, I setted ‘openssl_no_asm%’: 0 in common.gypi.
But i got some error when compiling:

gyp: name ‘v’ is not defined while evaluating condition ‘gas_version and v(gas_version) >= v(“2.26”) or nasm_version and v(nasm_version) >= v(“2.11.8”)’ in /mediasoup-3.5/worker/deps/openssl/openssl.gyp

It’s because we are using gyp, but nodejs is using node-gyp, and v is a function defined in node-gyp.
So we should either remove those lines(i’m not sure what are they used for) from \worker\deps\openssl\openssl.gyp or switch to node-gyp.

 'gas_version and v(gas_version) >= v("2.26") or '
           'nasm_version and v(nasm_version) >= v("2.11.8")', {
           # Require AVX512IFMA supported. See
           # https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html
           # Currently crypto/poly1305/asm/poly1305-x86_64.pl requires AVX512IFMA.
          'includes': ['./openssl_asm.gypi'],
        },

penguinol · May 18, 2020, 3:39am

Yes, there is no -O option currently, nodejs is using -O3 for release version by default.
You can add -O option in line 26 of common.gypi

github.com

versatica/mediasoup/blob/v3/worker/common.gypi

{
  'variables':
  {
    # libuv variables.
    'uv_library%': 'static_library',
    # openssl variables.
    'library%': 'static_library',
    'openssl_fips%': '',
    'openssl_no_asm%': 1, # Must be defined in OpenSSL >= 1.1.0g.
    'libopenssl': '<(PRODUCT_DIR)/libopenssl.a',
    # usrsctp variables.
    'sctp_debug%': 'false',
    # Others.
    'clang%': 0,
    'mediasoup_asan%': 'false'
  },

  'target_defaults':
  {
    'default_configuration': 'Release',

This file has been truncated. show original

Someone says -O3 is slower than -O2 in some situations, so we need to test it.

penguinol · May 18, 2020, 7:44am

Shall we switch to node-gyp and enable openssl_asm
Or keep using gyp and remove those uncompatible lines
Or just do nothing and wait for CMake

ibc · May 18, 2020, 9:39am

Hi, guys. The idea is dropping gyp and moving to CMake:

Topic		Replies	Views
Custom openssl dep compile options mediasoup libraries	5	834	June 29, 2020
fault during npm install: FAILED: subprojects/openssl-3.0.2 Deployment & Scalability	2	490	June 28, 2022
Mediasoup v2: Compile error "unrecognised cmd line option -m64" mediasoup libraries	6	939	December 2, 2019
Error with libopenssl when installing mediasoup in macOS mediasoup libraries	12	1602	December 2, 2019
Install mediasoup on device with apple m1 cpu (Error: unknown target cpu)) Deployment & Scalability	8	1670	November 15, 2022

Why compile openssl with no_asm by default?

Related topics